Files
property-management-network/app/api/files/[...key]/route.ts
T
Leon SerfatyandClaude Opus 4.8 969d5d4c8a Security hardening from 2026-07-01 audit
- Exclude supabase/ from Docker build context (leaked service_role key file)
- /api/files: exact per-user namespace match + reject path traversal;
  storage resolveKey rejects ".."/"." segments (fixes cross-user file read)
- Add ownsProperty/Unit/Tenant checks to tenants, maintenance (landlord path),
  and documents (JSON branch, now field-whitelisted) create handlers
- Escape user data in follow-up + payment-link emails (reuse escapeHtml)
- Neutralize CSV formula injection in toCsv + export routes
- Tighter sign-in rate limit (10/min); env-gated email verification + sender
- Per-request nonce CSP; drop script-src 'unsafe-inline' (styles unchanged)
- Add input length bounds; validate follow-ups POST body

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-01 13:56:34 -04:00

48 lines
1.9 KiB
TypeScript

import { NextResponse } from "next/server"
import { getSessionUser } from "@/lib/session"
import { readFile, contentTypeForKey } from "@/lib/storage"
// Only these image types are safe to render inline from our origin. Everything
// else (including svg, html, documents) is forced to download as an attachment.
const INLINE_EXTENSIONS = ["png", "jpg", "jpeg", "gif", "webp"]
// Auth-gated file serving. Storage keys are namespaced by user id
// (`<userId>/<scope>/<file>`), so a file belongs to the requester iff the key's
// first segment equals their session user id.
export async function GET(_: Request, { params }: { params: Promise<{ key: string[] }> }) {
const user = await getSessionUser()
if (!user) return NextResponse.json({ error: "Unauthorized" }, { status: 401 })
const { key: segments } = await params
// Reject traversal / malformed segments (no double-decode — params are already decoded).
const badSegment = segments.some(
(s) => s === "" || s === "." || s === ".." || s.includes("/") || s.includes("\\")
)
// Ownership: the first path segment must be EXACTLY the caller's user id.
if (badSegment || segments[0] !== user.id) {
return NextResponse.json({ error: "Forbidden" }, { status: 403 })
}
const key = segments.join("/")
try {
const buffer = await readFile(key)
const ext = key.split(".").pop()?.toLowerCase() ?? ""
const disposition = INLINE_EXTENSIONS.includes(ext) ? "inline" : "attachment"
const basename = (key.split("/").pop() ?? "file").replace(/["\\\r\n\x00-\x1f]/g, "")
return new NextResponse(new Uint8Array(buffer), {
headers: {
"Content-Type": contentTypeForKey(key),
"Content-Disposition": `${disposition}; filename="${basename}"`,
"X-Content-Type-Options": "nosniff",
"Cache-Control": "private, max-age=3600",
},
})
} catch {
return NextResponse.json({ error: "Not found" }, { status: 404 })
}
}