Storage→Spaces, security hardening, production-blocker fixes, tests + CI

Storage
- Migrate document/media storage from local disk to DigitalOcean Spaces (S3);
  lib/storage.ts now streams via the S3 SDK; SPACES_* env vars required.
- Add scripts/migrate-storage-to-spaces.ts (idempotent, one-time).

Security hardening (all report findings)
- DB pool fails closed in production when the CA cert is missing (no more
  silent unverified TLS); warns in dev.
- trustProxy: 1 (was true) so X-Forwarded-For can't be spoofed to evade rate limits.
- Login lockout keyed by (email, ip) so an attacker can't lock out a victim.
- Superadmin auto-grant now requires a verified email.
- CSRF tokens HMAC-signed; exact-path exemptions; logout no longer exempt.
- Upload content-sniffing (magic bytes) rejects spoofed MIME types.
- create-admin.ts reads creds from env/argv; seed-demo.ts guarded behind ALLOW_SEED.

Production-blocker fixes
- SPA deep-link/refresh no longer 500s (decorateReply fix); index.html served no-cache.
- Invoice numbering is transaction-safe (per-firm advisory lock + max sequence),
  eliminating concurrent collisions and delete-reuse — no schema change.
- Checkout guards against double-billing a firm already on a paid plan.
- Fix render-loop in CreateInvoiceDrawer / ManualEntryDrawer (unstable effect deps).

Honesty / trust
- Remove fabricated testimonials, stats, strikethrough "was" prices, contact SLA,
  and the login-panel stats; replace with non-fabricated copy.
- Fix cookie-policy consent-key mismatch. (Legal pages still need lawyer review.)

Quality
- Add Vitest unit tests (file-signature, password hashing) and GitHub Actions CI.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Leon Serfaty
2026-07-16 13:18:10 -04:00
co-authored by Claude Fable 5
parent 310568690b
commit 97e1d4c60b
51 changed files with 3640 additions and 660 deletions
+11 -2
View File
@@ -19,8 +19,17 @@ const envSchema = z.object({
WEB_DIST_PATH: z.string().optional(),
SUPERADMIN_EMAILS: z.string().optional().default(''),
SENTRY_DSN_API: z.string().optional().default(''),
STORAGE_PATH: z.string().min(1).default('./storage'),
RESEND_API_KEY: z.string().optional().default(''),
// Object storage — DigitalOcean Spaces (S3-compatible), the platform's sole storage backend.
// Required: the API must not boot into a state where uploads silently have nowhere to go.
SPACES_ENDPOINT: z.string().url(),
SPACES_REGION: z.string().min(1),
SPACES_BUCKET: z.string().min(1),
SPACES_KEY: z.string().min(1),
SPACES_SECRET: z.string().min(1),
SPACES_PUBLIC_BASE: z.string().optional().default(''),
// Legacy local path — read only by the one-time migration script, not the running app.
STORAGE_PATH: z.string().optional().default('./storage'),
SMTP2GO_API_KEY: z.string().optional().default(''),
EMAIL_FROM: z.string().optional().default('eLegal Software <noreply@elegalsoftware.com>'),
STRIPE_SECRET_KEY: z.string().optional().default(''),
STRIPE_WEBHOOK_SECRET: z.string().optional().default(''),